Skip to content
Submitted 4 months ago

QR-code-component

Gabriella Calvano•40
@Nymesia47
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud I've completed the challenge within a reasonable time considering my early stage of learning. Next time I will plan my workflow with more detail.

What challenges did you encounter, and how did you overcome them?

positioning elements on the page as well as margins/paddings were challenging to get right. I used some notes taken on courses I have done as well as google what other have done.

What specific areas of your project would you like help with?

I would like to know if there are ways to simplify my code and make it more efficient as well as improve the semantic markup of my HTML code, specifically to make it more accessible.

Community feedback

  • Dylan de Bruijn•3,230
    @DylandeBruijnPosted 4 months ago

    @Nymesia47

    Hiya! 👋

    Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

    Things you could improve ✍️

    • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

    • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

    • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

    • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

    • Try using semantic HTML elements like main, section and article.

    • It is possible to center your card using just flex or grid without margin or padding.

    I hope you find my feedback helpful! 🌟

    Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

    Happy coding! 😎

    Marked as helpful
    0
    Gabriella Calvano•40
    @Nymesia47Posted 4 months ago

    @DylandeBruijn

    Thank you for taking the time to review my code. Your feedback is really helpful. I have made some adjustment to the code after reflecting on your feedback and I will use your notes for future projects.

    Thank you again!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord