Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

Manuel Matusโ€ข 70

@ManudeQuevedo

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It is a straightforward project, I am retaking my frontend development skills so I'm starting from the basics. Any feedback would be appreciated, specifically on the semantics and the CSS rules.

Community feedback

@MelvinAguilar

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

I have other suggestions about your code that might interest you.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source ๐Ÿ“˜
  • The width: 100vw property in the body tag is not necessary. This will create a horizontal scrollbar on some devices. Also, the body tag is a block element and it will take the full width of the page by default.
  • Use min-height: 100vh instead of height: 100vh. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

    screenshot-imgur (landscape mode)๐Ÿ“ธ

I hope you find it useful! ๐Ÿ˜„

Happy coding!

Marked as helpful

3

Manuel Matusโ€ข 70

@ManudeQuevedo

Posted

@MelvinAguilar Thank you for your feedback.

Definitely, I will make those small fixes!

1
Aram Nayebbandiโ€ข 510

@devaramnye

Posted

I like that work-flow with importing a .css file with variables. Only thing which I would like is that if I view your project with my smartphone which has 320px, I have to scroll down. Maybe you can fix that in your code if you like to practise the quality of responsibility.

But I learned something of your code and I wish you a good day and happy coding.

Marked as helpful

1

Manuel Matusโ€ข 70

@ManudeQuevedo

Posted

@devaramnye Thank you for your feedback!

I decided to separate the CSS with the variables to have a central place where I know I can only focus on modifying the variable values if needed.

I normally do that, The styles.css is filled with @imports and I separate the CSS files for the specific areas, which makes it simpler for me to know which file has to be modified instead of scrolling through hundreds, sometimes even thousands of lines in a single CSS file.

I will definitely check the responsiveness of the site on smaller/bigger screens.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord