QR Code Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have other suggestions about your code that might interest you.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source 📘

  • The width: 100vw property in the body tag is not necessary. This will create a horizontal scrollbar on some devices. Also, the body tag is a block element and it will take the full width of the page by default.

  • Use min-height: 100vh instead of height: 100vh. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

    screenshot-imgur (landscape mode)📸

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  3

  ---

  

  Manuel Matus•70

  @ManudeQuevedoPosted over 1 year ago

  @MelvinAguilar Thank you for your feedback.

  Definitely, I will make those small fixes!

  1
• 

  Aram Nayebbandi•510

  @devaramnyePosted over 1 year ago

  I like that work-flow with importing a .css file with variables. Only thing which I would like is that if I view your project with my smartphone which has 320px, I have to scroll down. Maybe you can fix that in your code if you like to practise the quality of responsibility.

  But I learned something of your code and I wish you a good day and happy coding.

  Marked as helpful

  1

  ---

  

  Manuel Matus•70

  @ManudeQuevedoPosted over 1 year ago

  @devaramnye Thank you for your feedback!

  I decided to separate the CSS with the variables to have a central place where I know I can only focus on modifying the variable values if needed.

  I normally do that, The styles.css is filled with @imports and I separate the CSS files for the specific areas, which makes it simpler for me to know which file has to be modified instead of scrolling through hundreds, sometimes even thousands of lines in a single CSS file.

  I will definitely check the responsiveness of the site on smaller/bigger screens.

  1