Design comparison
Solution retrospective
Do you see something that I can improve upon? Don't be afraid to let me know as I am trying to improve as much as possible. Thanks!
Community feedback
- @NaveenGumastePosted over 2 years ago
Hello Shawtii ! Congo 👏 on completing this challenge
Let's look at some of your issues, shall we:
-
I too recommend you to use external css over internal css as it make you easy to maintain.
-
Font-color is not black its given in style-guide.md check that out.
happy Coding😀
1@CrypticMangoPosted over 2 years ago@Crazimonk Oh thank you for the tips I will check that out
1 -
- @jeancarlosruizPosted over 2 years ago
I see a great job in this challenge @CrypticMango,
2 little things you can modify in this challenge is
1: Remove the style tag from your .html file and move it into the .css 2: Add a footer tag in the attribution class to fix the accessibility issues
Happy coding!!!
1@CrypticMangoPosted over 2 years ago@Jean-FrontEnd okay I will look into these two things thanks for the help, appreciate it!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord