QR code component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Moshiur, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all margin from card body
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Moshiur Raihan•30

  @MoshiurRaihan95Posted almost 2 years ago

  @denielden Thanks for your valuable feedback.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @MoshiurRaihan95 you are welcome and keep it up :)

  0
• 

  suhayb jirde•1,050

  @suhaybjirdePosted almost 2 years ago

  congrats well done👏 for my advice try to remove these media quarries

  @media(min-width: 500px){
      .container{
          width: 400px;
      }
  }
  @media(max-width:767px){
      .container{
          padding: 1rem;
      }
      .container h1{
          font-size: 23px;
      }
      .container p{
          padding-left: 1.8rem;
          padding-right: 1.8rem;
      }
  }
  

  you can style it with out these check out my code for this challenge as a reference

  Marked as helpful

  1

  ---

  

  Moshiur Raihan•30

  @MoshiurRaihan95Posted almost 2 years ago

  @suhaybjirde Thanks for your valuable feedback.

  0