@denielden
Posted
Hello Moshiur, You have done a good work! π
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all
margin
fromcard
body - after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help π and Happy coding!
Marked as helpful
@MoshiurRaihan95
Posted
@denielden Thanks for your valuable feedback.
@denielden
Posted
@MoshiurRaihan95 you are welcome and keep it up :)