Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Moshiur Raihanβ€’ 30

@MoshiurRaihan95

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What did you find difficult while building the project? Ans: This is my first project, at first I don't understand how I start. But when I ask google, it's become much easier. Which areas of your code are you unsure of? Ans: Nothing else. Do you have any questions about best practices? Ans: Please review my code and describe me best coding practice. Thanks.

Community feedback

Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hello Moshiur, You have done a good work! 😁

Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all margin from card body
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

Keep learning how to code with your amazing solutions to challenges.

Hope this help πŸ˜‰ and Happy coding!

Marked as helpful

1

Moshiur Raihanβ€’ 30

@MoshiurRaihan95

Posted

@denielden Thanks for your valuable feedback.

1
Travolgi πŸ•β€’ 31,420

@denielden

Posted

@MoshiurRaihan95 you are welcome and keep it up :)

0
suhayb jirdeβ€’ 1,050

@suhaybjirde

Posted

congrats well doneπŸ‘ for my advice try to remove these media quarries

@media(min-width: 500px){
    .container{
        width: 400px;
    }
}
@media(max-width:767px){
    .container{
        padding: 1rem;
    }
    .container h1{
        font-size: 23px;
    }
    .container p{
        padding-left: 1.8rem;
        padding-right: 1.8rem;
    }
}

you can style it with out these check out my code for this challenge as a reference

Marked as helpful

1

Moshiur Raihanβ€’ 30

@MoshiurRaihan95

Posted

@suhaybjirde Thanks for your valuable feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord