Skip to content
Submitted 3 months ago

QR code component

Kseniia Masna•50
@KseniiaMasna
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • P
    Øystein Håberg•12,740
    @Islandstone89Posted 3 months ago

    Good job!

    A few suggestions:

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Wrap the card in a <main>.

    • The alt text should be written naturally, without using - between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    • Change .attribution to a <footer>, and use <p> for the text inside. The <footer> must be outside of the <main>, both being Driect children of the <body>.

    CSS:

    • Including a CSS Reset at the top is good practice.

    • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

    • Remove position: absolute on .attribution.

    • You can remove justify-content: flex-start on the card, as that is the default value.

    • On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport. Add gap: 20px, to create a bit of space between the <main> and the <footer>.

    • Remove width: 100% on .text-content, it is not needed.

    • max-width on the card should be in rem. Around 20rem (equals 320px) works well.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • letter-spacing must also not be in px. You can use em, where 1em equals the element's font size.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

    • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

    Marked as helpful
    1
    Kseniia Masna•50
    @KseniiaMasnaPosted 3 months ago

    @Islandstone89 Thank you very much for your so detailed and constructive feedback. It helped me a lot!

    1
  • tiedej2000•320
    @tiedej2000Posted 3 months ago

    looks good :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord