QR Design Using HTML and CSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded

  There is no need for the height value in .container replace it with a padding value for all the sides. .container{padding:15px;}

  Give the img a max-width of 100% instead of width and height value, and a border-radius of 15px instead this will apply to all the corners of the image instead of border-left-radius value. the rest of styling are not needed. there is no need to style .pic and give it a border-radius value because the img is the same as .pic

  Give h1 and p a font-size of 15px, the same padding-left and padding-right value, text-align: center and the same margin-top value . give p a margin-bottom value and opacity: 0.5 for the faded color. h1, p{ padding: 0 15px; margin-top: 15px; text-align-center; font-size: 15px;} p{ margin-bottom: 15px; opacity: 0.5;}

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .container on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  Eduardo Daniel•120

  @202745EsquedaDanielPosted almost 2 years ago

  Hi, just renember

  Four values - border-radius: 15px 15px 0 0; (first value applies to top-left corner, second value applies to top-right corner, third value applies to bottom-right corner, and fourth value applies to bottom-left corner):

  0