QR code component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Rob Meijer, congratulations for your first solution! 👋 Welcome to the Frontend Mentor Coding Community!

  Your solution is great and its really pixel perfect! The suggestions I've for your are all related to the code. For example:

  Instead of using a h4 you have to use h1 in this case since this is the main title.

  To reduce the html structure and improve the html markup cleaning the code you can replace the main div with <main> and delete all the other divs, all you need is a single block to hold all the content -- <main> <img> <h1> <p> </main> is all you need.

  Then to have your solution pixel perfect you need a margin to avoid the container borders touching the screen edges while it scales, a good value is margin: 20px for the card.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Rob Meijer•100

  @robmeijerPosted about 2 years ago

  @correlucas Thank you for the suggestion, I appreciated it!

  1
• 

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  Hi @robmeijer, how are you? Welcome to the front-end mentor community. I really liked the result of your project, but I have some tips that I think you will like.

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  2- Page should contain a level-one heading, you could have changed h4 to h1 click here to read about it

  The rest is really good!

  Hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Rob Meijer•100

  @robmeijerPosted about 2 years ago

  @AdrianoEscarabote Thank you! I have implemented these changes.

  1

  

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  @robmeijer no problem, keep coding

  0