qr-code-challeng HTML, css basics

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  To fix the report issue you need to use the main tag instead of div with the class "sector", like so

  <main class="sector"></main>
  
  

  Marked as helpful

  0

  ---

  

  oshaxgio•60

  @oshaxgioPosted almost 2 years ago

  @catherineisonline thank you for advice.))

  0

  

  oshaxgio•60

  @oshaxgioPosted almost 2 years ago

  @catherineisonline thank you for advice.))

  0
• 

  Adriano•38,290

  @AdrianoEscarabotePosted almost 2 years ago

  Hello oshaxgio, how are you? Welcome to the community of front-end mentors! I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.

  A document ought to have one primary landmark, and the absence of a main tag around the page's primary content is the root of this issue. On this page, there is no other element that is more important than the one that this challenge is based on, so to solve it, wrap all the content in the'main' tag.

  It's always a good idea to pay close attention to the proper use of semantic html elements because they are crucial for screen reader users to understand what the main content of the page is in the case of the'main' tag!

  The remainder is excellent.

  I hope it's useful. 👍

  0

  ---

  

  oshaxgio•60

  @oshaxgioPosted almost 2 years ago

  @AdrianoEscarabote thank you for advice, it really helpfull.

  1