Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-challeng HTML, css basics

oshaxgio 60

@oshaxgio

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


hello i'm beginer in all aspects so i'll be thankfull for every comment ))

Community feedback

@catherineisonline

Posted

To fix the report issue you need to use the main tag instead of div with the class "sector", like so

<main class="sector"></main>

Marked as helpful

0

oshaxgio 60

@oshaxgio

Posted

@catherineisonline thank you for advice.))

0
oshaxgio 60

@oshaxgio

Posted

@catherineisonline thank you for advice.))

0
Adriano 34,090

@AdrianoEscarabote

Posted

Hello oshaxgio, how are you? Welcome to the community of front-end mentors! I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.

A document ought to have one primary landmark, and the absence of a main tag around the page's primary content is the root of this issue. On this page, there is no other element that is more important than the one that this challenge is based on, so to solve it, wrap all the content in the'main' tag.

It's always a good idea to pay close attention to the proper use of semantic html elements because they are crucial for screen reader users to understand what the main content of the page is in the case of the'main' tag!

The remainder is excellent.

I hope it's useful. 👍

0

oshaxgio 60

@oshaxgio

Posted

@AdrianoEscarabote thank you for advice, it really helpfull.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord