QR code component

Community feedback

• 

  Hamid Mahmood•540

  @Hamid210545Posted about 2 years ago

  Hello ..... you have done an amazing job.... but let me correct you ... your card is not in center of the screen as per as design requirements.... but you can fix it by taking one simple step: by setting the properties of body tag { display: flex ; justify-content: center ; align-items: center ; } ............... I hope this will fix your problem............ Thanks!

  1

  ---

  

  Ashiqur Rahman•10

  @muhammadashiqurrahmanPosted about 2 years ago

  Thank you @Hamid210545 for your kind help. Hope your suggestion grow up as a professional

  0

  

  Ashiqur Rahman•10

  @muhammadashiqurrahmanPosted about 2 years ago

  Thank you @Hamid210545 for your kind help. Hope your suggestion grows up as a professional

  0

  

  Hamid Mahmood•540

  @Hamid210545Posted about 2 years ago

  @muhammadashiqurrahman You are always welcome💖

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @muhammadashiqurrahman 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="container">.

  • Additionally, you can use the <article> tag instead of div to the container card: <div class="qr_wrapper">.

  • Use an h1 tag for your solution. The <h1> element is the main heading on a webpage, also, there should only be one <h1> tag per page. Swap the <h2> tag with <h1>.

  • The alternate attribute text must not contain hyphens or underscores, it must be human readable.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • The container isn't centered correctly. You can use flexbox to center elements. You can read more about centering in CSS here.

  Above all, the project is done well👏. I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  1

  ---

  

  Ashiqur Rahman•10

  @muhammadashiqurrahmanPosted about 2 years ago

  Thank you @MelvinAguilar for your kind help. Hope your suggestion grows up as a professional

  0

  

  Ashiqur Rahman•10

  @muhammadashiqurrahmanPosted about 2 years ago

  Thank you @MelvinAguilar for your kind help. Hope your suggestion grows up as a professional

  1
• 

  { D D D }•150

  @DavidDelannoyDeveloppementPosted about 2 years ago

  Hi Ashiqur !!! If you need help finishing your challenge, don't hesitate ! I can help you with no problem. 😉

  1

  ---

  

  Ashiqur Rahman•10

  @muhammadashiqurrahmanPosted about 2 years ago

  Thank you @DavidDelannoyDeveloppement

  0