QR code component

Community feedback

• 

  dimar hanung•560

  @dimar-hanungPosted over 1 year ago

  Hello! 🖐️ Well done on completing the challenge 🎉

  I have some interest and feedback with your code

  That i like:

  1. I appreciate the similarity of your results with the design, a bit different in scale but still good
  2. html is pretty good, not too nested 👍
  3. Responsive until galaxy fold screen size 👌
  4. CSS Naming is also good, represent what is it for, like <div class="card"> for card section

  My Feedback:

  • I suggest you use html semantic convention, for example <div class="container"> to <main class="container">, it will make it clearer, and will improve seo if you want to submit your website to google, i recomended this article: here

  • you can seperate file by folder to be more structured, for example:

    public/
    ├─ images/
    │  ├─ qr-code-image.png
    ├─ styles/
    │  ├─ main.css
    ├─ favicon.png
    index.html
    
    

  anyways overall is good, nice solution, hope it useful 🙌

  0

  ---

  

  Omar Elqady•90

  @OmarElqady04Posted over 1 year ago

  thanks

  @dimar-hanung

  0