Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Omar Elqadyโ€ข 90

@OmarElqady04

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

dimar hanungโ€ข 560

@dimar-hanung

Posted

Hello! ๐Ÿ–๏ธ Well done on completing the challenge ๐ŸŽ‰

I have some interest and feedback with your code

That i like:

  1. I appreciate the similarity of your results with the design, a bit different in scale but still good
  2. html is pretty good, not too nested ๐Ÿ‘
  3. Responsive until galaxy fold screen size ๐Ÿ‘Œ
  4. CSS Naming is also good, represent what is it for, likeย <div class="card">ย for card section

My Feedback:

  • I suggest you use html semantic convention, for exampleย <div class="container">ย toย <main class="container">, it will make it clearer, and will improve seo if you want to submit your website to google, i recomended this article:ย here

  • you can seperate file by folder to be more structured, for example:

    public/
    โ”œโ”€ images/
    โ”‚  โ”œโ”€ qr-code-image.png
    โ”œโ”€ styles/
    โ”‚  โ”œโ”€ main.css
    โ”œโ”€ favicon.png
    index.html
    
    

anyways overall is good, nice solution, hope it useful ๐Ÿ™Œ

0

Omar Elqadyโ€ข 90

@OmarElqady04

Posted

thanks

@dimar-hanung

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord