Skip to content
Submitted almost 2 years ago

QR code component (HTML & CSS, BEM and FLEXBOX)

Ignacio Figueroa•250
@ignaciofigueroadev
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hey there! 🫡 this is Nacho

This is my solution of the "Qr code component challenge"

How was my experience in this project?

It was very funny and easy for me 😀 I liked this challenge.

What I used in this challenge?

  • HTML & CSS
  • Flexbox
  • BEM
  • Mobile-first workflow

I want to know your feedback! any tip or advice are helpful and welcome

Cheers!

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted almost 2 years ago

    Hello there 👋. Good job on completing the challenge !

    I have some feedback for you if you want to improve your code.

    Alt text 📷:

    • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

    • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

      If you want to learn more about the alt attribute, you can read this article. 📘.

    CSS 🎨:

    • The width: 100vw property in the body tag is not necessary. The body tag is a block element and it will take the full width of the page by default.

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    1
    Ignacio Figueroa•250
    @ignaciofigueroadevPosted almost 2 years ago

    @MelvinAguilar Thanks for your feedback buddy 😁

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord