Design comparison
Solution retrospective
In this challege I had a difficultie with the link. On github.io do not worked, for some reason the picture just do no show. I don't know if had some error with my files.
- https://barbaradamasdev.github.io/qr-code-component-main/
- https://lighthearted-toffee-ea573a.netlify.app/
Please give me your feedback, it'll help a lot. Thank! :)
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of
semantic
markup, which causes lacking of landmark for a webpage
- So fix it by replacing the
<div class="content">
element with the semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>
element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
- The
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@barbaradamasdevPosted over 1 year ago@0xAbdulKhalid thank you so much, I totally get it. It was a perfect explanation, I appreciate it 😄❤️
0 - @seanryderjrPosted over 1 year ago
You nailed it. Don't you love how there are so many ways to do things with CSS?
1@barbaradamasdevPosted over 1 year ago@seanryderjr tks 😄. I definitely love it, it's amazing 👏🏻❤️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord