QR Code Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some feedback for you if you want to improve your code.

  HTML 📄:

  • In spite of the fact that this challenge does not take up an entire page, I feel there should not be a <header> on the page. It is not necessary to wrap an image inside a <header> element. The <header> element is used to define the header of a document or section, and usually contains introductory content such as a logo, navigation links, or search form.

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

  • Why don't you use "height: 80vh;" instead of making it take up the full height of the viewport?

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Jason Solarz•60

  @JasonSolarzPosted almost 2 years ago

  @MelvinAguilar

  Hi Melvin,

  Thanks for taking the time to review my code!

  I appreciate all the feedback and will use this feedback going forward.

  1