QR code component

Community feedback

• 

  Hoshiko•180

  @oliwiakrammPosted almost 2 years ago

  This comment was deleted 10 months ago

  0

  ---

  

  Magdalena•500

  @magsaramPosted almost 2 years ago

  @oliwiakramm Dzięki!

  Uczę się CSS kilka dni i oczywiście chciałam już się tym pobawić, dlatego tak koślawo wychodzi. Do flexbox i grid jeszcze nie doszłam, a właśnie było o position. Użyłam tego, bo inaczej footer nie chciał mi zjechać na sam dół... Cóż, to jeszcze trochę przede mną :)

  0

  

  Magdalena•500

  @magsaramPosted almost 2 years ago

  @oliwiakramm jasne, dlatego teraz robię najprostsze ;) Wolę najpierw robić sama i kombinować, żeby uczyć się myślenia. Ale potem będę zaglądać, pewnie :)

  1
• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.

  I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

  Happy <coding /> 😎!

  Marked as helpful

  0

  ---

  

  Magdalena•500

  @magsaramPosted almost 2 years ago

  @frank-itachi Hi Frank, thank you for comment, you're right, I forgot about <main>...

  0

  

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  @magsaram Glad to help.

  Happy <coding /> 😎!

  0
• 

  Dimitar Radev•930

  @Mitko90Posted almost 2 years ago

  Congratulations on completing your first challenge. It looks great.

  If you want to avoid the Accessibility warnings replace your <div class="frame>" with <main class="frame"> and put your heading in <h1> tag, instead of <p>

  Hope I'm helpful

  Marked as helpful

  0

  ---

  

  Magdalena•500

  @magsaramPosted almost 2 years ago

  @Mitko90 yep, you're right, I should use main... Thank you!

  0