Skip to content
Submitted almost 2 years ago

QR code component

Reza Jaber•200
@rezajaber
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hey! I am Reza 🙂 I just recently started to learn web-development and would like to get every little help out there. So if you have the time, feel free to look over my project/projects and give me some advice to get better as fast as possible.

Some questions for this "QR-Code" Project:

  1. Is my "Index.html" well structured?
  2. Did I center everything right, or was there a easier way?
  3. What did I do completely wrong, and just have luck within this project?
  4. Grid or Flex? Why did i need another grid/center at my last paragraph? Is it because of the individual width?

I appreciate it✌️

Community feedback

  • Adriano•38,390
    @AdrianoEscarabotePosted almost 2 years ago

    Hi Reza Jaber, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

    To make it easier to make the project responsive, use max-width rather than width.

    To improve the structure of the html document, prefer to wrap all the content with the main tag, since this challenge is just a component, it needs a main tag to know what the main content of the page is!

    As you know this project is based only on one page component, so no h1 is needed! because we don't know if this page will have a more important component, but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

    <h1 class="catcher">Improve your front-end skills by building projects</h1>

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    0
    Reza Jaber•200
    @rezajaberPosted almost 2 years ago

    @AdrianoEscarabote Hey Adriano, I am fine :) I hope that you are too! Thank you for your help, this was some great advice 😁

    Just yesterday I was talking with a friend of mine about you and how nice your work is, so thank you for taking your time. I really appreciate it🙏

    1
    Adriano•38,390
    @AdrianoEscarabotePosted almost 2 years ago

    @rezajaber thanks! 😁 happy coding!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord