QR code component

Community feedback

• 

  bhushan pagare•20

  @bhushanpagare054Posted about 2 years ago

  thank you for giving me advice I am new in this field I would definitely work on it...thank you again...

  0

  ---

  

  Rachit Patel•540

  @rachit0706Posted about 2 years ago

  @bhushanpagare054 If you found my suggestions helpful, I would request you to mark my comment as helpful.

  0
• 

  Rachit Patel•540

  @rachit0706Posted about 2 years ago

  Congratulations for completing the challenge! But I have a few suggestions for you:

  1. You should use a seperate css file for writing all your styles and then link it to the html.
  2. You have put wrong path in the img tag src attribute. Because of this the image is not rendering. 3 .Your body is not taking the whole width and height of the page. Set padding and margin to 0 and give min-height as 100vh to body tag.
  3. You shouldn't make the body as flex box container. Instead instead use main element inside body and then a div to wrap the content. Then you can set the display as flex for that container div.

  0