QR Code Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi @trunglam7 👋, good job completing this challenge! 🎉

  At the moment, it is a very well structured and excellent piece of work 👏, also, I have some suggestions you might consider to improve your code:

  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. You can read more about this problem here.

  • Use min-height: 100vh to the main selector instead of height. This property lets you set a height and let the element grow even more if necessary.

  • Use max-width: 300px to .qr-container selector instead of width, this will make the container card a bit responsive on mobile and set the element's maximum width to 300px.

  Please don't worry if your suggestions are long, they are just details. In the end, the project is well done 👏. Hope you find those tips helpful! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  1

  ---

  

  Trung Lam•270

  @trunglam7Posted almost 2 years ago

  @MelvinAguilar Thank you for this feedback! This is very informative and helpful for this project and future projects.

  1