Frontend master landing page using qr code

Community feedback

• 

  Bhargav Kumar•10

  @bhargavjyotiPosted almost 2 years ago

  Great work! Here are some feedbacks.

  1. Center the card component using Flexbox or Gird.
  2. Use the font family provided inside style-guide.md file.
  3. Use colors given in the style-guide.md file.
  4. Write more descriptive README.md when uploading to GitHub.
  5. If using VS Code, write "!" and hit tab inside html file to get a better boilerplate.

  0
• 

  Basant Soni•450

  @SoniBasantPosted almost 2 years ago

  1. Use flex to make it center.
  2. Font family and background-color are given in style-guide.md but I'm also writing it here-

  • font-family: Outfit;
  • background-color of body : hsl(212, 45%, 89%);
  • font-color for p: hsl(220, 15%, 55%);
  • background color of qr-code and content: hsl(0, 0%, 100%)

  3. border radius of image should be small than the its surrounding white background.

  Good luck. Keep improving and learning. : )

  0