QR code component

Community feedback

• 

  Chris Jay•220

  @chrisjay358Posted almost 2 years ago

  Hi Alexander, I think you did a good job, and if you want to make it even better, here are my observations that you can add.

  • The color of the <p> text.

  .qr-body p {
    color: var(--gray-blue);
  }
  

  • You could also have used

  <article class ="container"></article> instead of <div class ="container">
  

  It is better for semantics and helps screen readers also.

  • You can reduce the padding on the inside also.

  Above all this I called out, you did a pretty amazing job considering you've been off for a while. Keep winning and growing Alexander Pena!

  Marked as helpful

  1
• 

  7milkyways•100

  @iamdestinychildPosted almost 2 years ago

  you did a really wonderful job, just follow the style guide as previously mentioned

  Marked as helpful

  0