Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Code desktop-first solution

Pragya Anand• 40

@pragya703

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah• 50,690

@Hassiai

Posted

Replace <div class="container"> with the main tag and <p class="heading"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

There is no need to give the body a height value . There is no need to style .container, the body has a wrong background-color.

To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

To center .container on the page using flexbox:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
To center .container on the page using grid:
body{
min-height: 100vh;
display: grid;
place-items: center;
}

This challenge does not require a box-shadow.

For a responsive content, replace the width in .qrcode with max-width. e.g ' max-width:375px'. there is no need for the height value in .qr-code

Give p and h1 the same margin-left, margin-right and margin-top values instead of a width values. Give p and h1 the same font-size of 15px. Give p a margin- bottom value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord