non-responsive page using only HTML and CSS

Hello there 👋. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML 📄:

• Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

• Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

• Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).

• The <br> tag is not a semantic element. If a screen reader user is reading the page, they will hear "line break", which breaks the flow of the content. Instead, use CSS properties like margin, padding or max-width to add vertical space between elements.

Alt text 📷:

• The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

• The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

  If you want to learn more about the alt attribute, you can read this article. 📘.

CSS 🎨:

• The width: 100vw property in the .container tag is not necessary. This will create a horizontal scrollbar on some devices.

• Use min-height instead of height: 90vh. The height property will not work if the content of the page grows beyond the height of the viewport.

• You should use a max-width of 320px or 20rem to make sure that the component will have a maximum width of 320px on any device.

  .content-container {
      max-width: 320px;
  }
  

• Update the image selector to make responsive images:

  .qr {
      width: 100%;
      border-image: url(images/image-qr-code.png);
      border-radius: 10px;
  }
  

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!