QR Code Component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="container">with the main tag, <p class="title"> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .container on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .container on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  For a responsive content, replace the width in container width max-width. max-width:300px. Replace the height in .card with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement. padding: 16px.

  Give the img a max-width of 100% for a responsive image instead of a width and a border-radius value, the rest are not needed.

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  suhendripurnama•40

  @suhendripurnamaPosted over 1 year ago

  @Hassiai Thank you your input it's very helpful

  0
• 

  Dion•150

  @dionlowPosted over 1 year ago

  Really solid submission. The component is centered and has all the right colors.

  Some Feedback: It doesn't look like the fonts are loading as the link you provided as the source is the page link. You can either swap our for the embed link or download the fonts in the repo and import directly.

  0

  ---

  

  suhendripurnama•40

  @suhendripurnamaPosted over 1 year ago

  @dionlow thank you, i am trying to generate screenshot and the result still same

  0