QR code component

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Josue David Lopez Florian, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  A document ought to have one primary landmark, and the absence of a main tag around the page's primary content is the root of this issue. On this page, there is no other element that is more important than the one that this challenge is based on, so to solve it, wrap all the content in the'main' tag.

  It's always a good idea to pay close attention to the proper use of semantic html elements because they are crucial for screen reader users to understand what the main content of the page is in the case of the'main' tag!

  This page doesn't even need a "h1" because it is just a component, as you are aware. because we don't know how crucial the site's other elements will be! However, it's always advisable to avoid accessibility errors, so I believe it would be beneficial for you to include a "h1" in this component. This is also a good practice for when you are creating larger websites, so don't worry if you forget to include a "h1".

  <h1>Improve your front-end skills by buildind projects</h1>

  The remainder is excellent.

  I hope it's useful. 👍

  0

  ---

  

  Josue David Lopez Florian•180

  @JUMPSTONIKPosted almost 2 years ago

  @AdrianoEscarabote thank you for your suggestions. I already applied all your advices.

  0