Qr code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="qr"> with the maing tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .qr on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Give the img a max-width of 100% instead of a width value , there is no need to give .qr a height value the padding value is sufficient for that. give h1 the padding left and padding right values.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Yassine Boukhla•180

  @yassineboukhlaPosted almost 2 years ago

  @Hassiai Your reply is appreciated Hassia, Thank you very much.

  0