QR code component

Community feedback

• 

  Aimal Khan•2,260

  @Aimal-125Posted over 1 year ago

  In your CSS code, increase the height of body element to 120 or 150vh by using media query with max-height: 400px; so that your solution look good on screens with small heights.

  Marked as helpful

  1

  ---

  

  ahmed-abbe•90

  @ahmed-abbePosted over 1 year ago

  @Aimal-125 Thanks! so I should add this to my current code right? @meida (max-height: 400px) { body { min-height: 150vh; } }

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with QR Code is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  ahmed-abbe•90

  @ahmed-abbePosted over 1 year ago

  @0xAbdulKhalid Thanks! I will update my code and take that into account next time I'm coding. Happy coding to you too!

  0