Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <section> with the main tag and <p class="header"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .con on the page using flexbox, replace the height in the body with min-height:100vh.

  for a responsive content, replace the width of .con with max-width value to prevent the content from covering the entire screen withe size of 375px.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Julius Duff•90

  @jlsdffPosted almost 2 years ago

  Thanks @Hassiai, I appreciate your feedback.

  0
• 

  Kyrylo Haiduk•420

  @superpooperxxxPosted almost 2 years ago

  Hello, Julius, good job. Small fixes could be added to improve your code.

  You have an empty alt attribute on <img>, this is a bad practice for search engines. Add something like alt="QR code to go to frontendmentor.io". Also get rid of srcset="", cause you are not using any alternative path to image. <img src="images/image-qr-code.png" alt="" srcset="">

  Also to improve semantic use some heading tag here, for example <h1> <p class="header">Improve your front-end skills by building projects</p>

  Marked as helpful

  0

  ---

  

  Julius Duff•90

  @jlsdffPosted almost 2 years ago

  Thanks Kyrylo, I appreciate your feedback.

  0