Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code

Hamdi Shiliβ€’ 70

@Hamdi-git

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hatem Henchirβ€’ 530

@hatemhenchir

Posted

Hey Hamdi Shili, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:

  • try to move all the styles to file .css for clean code.
  • To identify the main content of your site you will want to encase your entire component inside a Main Element. You can do it by replace <div class="layout"/> with <main class="layou"/>
  • Implement a Mobile First approach πŸ“± > πŸ–₯

With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸ‚πŸ¦ƒ

Marked as helpful

0

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

Congrats on completing your first challenge!πŸŽŠπŸŽ†

  • It is best practice to have separate files for you HTML and CSS code. It helps keep things organized and make it easier to maintain.
  • Reduce πŸ“‰ the width of you component to better match the FEM design.
  • Change width to max-width in your component’s container to make it responsive.
  • A media query is not needed for this challenge. Using responsive properties will do in making your content responsive.
  • The alt tag description for the β€œQR image” needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!πŸŽ„πŸŽ

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord