Design comparison
Solution retrospective
Welcome Feedback is open
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Abdukadir, congratulations for your first solution! 👋 Welcome to the Frontend Mentor Coding Community!
👨💻 Here’s some tips to improve your solution code:
Your component is done and the code is working, but the html markup/structure can be reduced by removing unnecessary divs, all you need is a single
<main>or<div>to keep all the content inside, and nothing more. The ideal structure is thedivand only the image, heading and paragraph.YOUR CURRENT CODE:
<body cz-shortcut-listen="true"> <div class="container"> <div class="card"> <img src="image-qr-code.png" alt=""> <h2>Improve your front-end skills by building projects</h2> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </div> </div> </body>THE CODE WITH THE REDUCTION: Here’s a minimal html structure for this challenge:
<body> <main> <img src="./images/image-qr-code.png" alt="Qr Code Image" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>Here’s a good guide for writing a concise and clean code: https://altcampus.school/posts/writing-semantically-correct-and-clean-html
✌️ I hope this helps you and happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord