@Helter5
Posted
Site is good and its also responsive. Code is readable and well-structured. Solution has structurally have same logic.
Marked as helpful
What are you most proud of, and what would you do differently next time?
Recap on Html and CSS used goggle to re-visit of the html and css code example to refresh my knowledge.
@Helter5
Posted
Site is good and its also responsive. Code is readable and well-structured. Solution has structurally have same logic.
Marked as helpful
@gmagnenat
Posted
Hi, congrats on completing this challenge ! I see you completed several challenge but they all have some common issues on fundamentals that you should work on before moving to more complex layouts. I hope you'll find something useful in these comments to help you improve your coding skills.
Does the solution include semantic HTML?
Is it accessible, and what improvements could be made?
body {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100svh;
}
rem
. Use relative units for your max-width in rem
as well. A container with text, need to be flexible and able to scale according to the user preference. If you set fixed value you can have issues with content overflowing.Does the layout look good on a range of screen sizes?
Is the code well-structured, readable, and reusable?
I hope this helps you refactor this solution and your other ones. Understanding and fixing most of these issues will be very beneficial to avoid complex layout problems later.
Happy coding !
@LeowWeiLee
Posted
@gmagnenat
Please help review if I have gotten your comment correctly.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord