QR code component

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 18 days ago

  Hey, good job!

  Here are some suggestions for an even better solution:

  HTML:

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Move font-family and font-size from * to body. Remove font-weight: 400, as that is the default value.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • Remove all widths and heights in px. We rarely want to give a component a fixed size, as we want it to grow and shrink according to the screen size.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • letter-spacing must also not be in px. You can use em, where 1em equals the element's font size. NB: whenever the value is zero, it's enough to write 0, without including any units.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add height: auto and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  Marked as helpful

  1

  ---

  

  P

  ttwmf•100

  @ttwmfPosted 18 days ago

  @Islandstone89 Thanks for your suggestions. I've updated the solution. Could you please take a look?

  1

  

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 18 days ago

  @ttwmf looks good!

  A few minor things:

  • I would use em on letter-spacing.

  • height: auto on the card is not needed.

  • Remove font-size on the html. 16px is the default font-size value, so you don't have to declare it explicitly.

  Marked as helpful

  0

  

  P

  ttwmf•100

  @ttwmfPosted 17 days ago

  @Islandstone89 thanks for your feedback.

  1
• 

  chukwuma jennifer•80

  @jhenniiferPosted 18 days ago

  This is good, well done.

  0