Skip to content
Submitted 11 months ago

QR code component

Julio Peña•50
@JulioCode13
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello to all Challenge finished, I would appreciate your criticism so I can keep improving, if there is anything I can improve with my syntax. 💪​

I would appreciate your comments​✌️​

Community feedback

  • Marcos Travaglini•4,840
    @BlackpachamamePosted 11 months ago

    Greetings! you have done a great job 😎

    📌 Some suggestions

    • To improve the semantics of your HTML, you can change your <div class="container_card"> to a <main class="container_card">
    • You can apply display: block to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements
    • Use min-height and max-width, this will help the content stretch or shrink if you need to. Unlike height and width which can cause your content to be cut off on certain screens
    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord