QR code component

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 7 days ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Wrap the card in a <main>.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • Headings should always be in order, so you never start with a <h3>. I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • There is no need to wrap the image or the text in a <div>.

  • It's good practice to give elements a class.

  • With all this, your HTML structure should look like this:

  <main>
    <div class="container">
      <img src="images/image-qr-code.png" class="qr-code" alt="QR code leading to the Frontend Mentor website.">
      <h2 class="heading">Improve your front-end skills by building projects<h2>
      <p class="text">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </div>
  </main>
  

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove all widths and heights in px and %.

  • max-width on the card should be in rem. Around 20rem will work fine.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • letter-spacing must also not be in px. You can use em, where 1em equals the element's font size. NB: In CSS, whenever the value is zero, you don't need to include an unit - write 0.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • On the image, add display: block, height: auto and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • Selectors like .container .content h3 increase specificity, thus making it harder to override. As mentioned above, adding classes to elements is recommended, and using that as the selector.

  0
• 

  Sergii Volodarskyi•30

  @svolodarskyiPosted 7 days ago

  everything looks good, good job

  0