Submitted over 1 year ago

QR code component

Deivida Gaizauskaite• 50

@DEIVIDA

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Feel free to comment on anything you find wrong about my solution. Thanks!

Community feedback

Melvin Aguilar 🧑🏻‍💻• 61,220

@MelvinAguilar

Posted over 1 year ago

Hello there 👋. Good job on completing the challenge !

I have one suggestions about your code that might interest you.

Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

screenshot-imgur (landscape mode)📸

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

Deivida Gaizauskaite• 50

@DEIVIDA

Posted over 1 year ago

@MelvinAguilar I am grateful. Thank you!

Atif Iqbal• 3,200

@atif-dev

Posted over 1 year ago

Hi Deivida Gaizauskaite, congrats🎉 on completing the challenge. Better take care about following points.

Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To avoid accessibility issue "All page content should be contained by landmarks" use code as :

<body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

(why main matters? Read here)

When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

Hope you will find this Feedback Helpful.🙂

Marked as helpful

Deivida Gaizauskaite• 50

@DEIVIDA

Posted over 1 year ago

@atif-dev I am grateful for the feedback. Thank you!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord