Skip to content
Submitted 5 months ago

QR code component

better-ethan•60
@better-ethan
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

clear default margin and padding

What challenges did you encounter, and how did you overcome them?

just forget flex api sometimes.

need more practices

What specific areas of your project would you like help with?

just help me review my code

Community feedback

  • Miller•30
    @miller-daniloPosted 5 months ago

    Hi, better-ethan

    Good job on your solution for the challenge. Some things to consider for the future.

    it is not good idea use always <div>, use semantic HTML, it helps you to structure your HTML in a better way. Check this page Semantic HTML

    Additionally, I recommend you always use style sheets files instead of adding styles directly in the HTML file. Separated files help to read and understand better your code.

    Another think I saw is that the size of QR code card is a few different that the design, maybe you need to check the sizes during the testing of your solution. In my case, I used a screen ruler to check sizes and spaces. Maybe, it can be a good idea for you.

    Continue with your good effort.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord