Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr code component

@jagadeesan7

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All positive quarries accepted

Community feedback

@Agnik7

Posted

Hi, Congratulations on completing this challenge. I have some suggestions, which I think will help improve your skill.

  • For the footer text, use the footer tag instead of div.
  • Wrap all the content inside the body tag, except the footer tag, in main tag.
  • Replace the h2 tag with an h1 tag. This will get rid of the accessibility issue.
  • The image can't be viewed, because the code doesn't know where to search for the images folder. To fix that, add a ./ at the start of the source of the img tag.
Replace 
<img src="images/image-qr-code.png" alt="Qr">

with

<img src="./images/image-qr-code.png" alt="Qr">
  • For the container, instead of specifying the width, specify only the max-width. This will help achieve responsiveness, and you will also not need the media query.

Hope this feedback helps you.

Have a nice day!!

0
re:shono 10

@giorgishonia

Posted

Im not the one to judge but what's this

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord