Design comparison
Solution retrospective
All feedback is welcome, thank you in advance
Community feedback
- @Irwing-DevPosted 9 months ago
Hi Deomar! 👋
As you use github pages, your index.html doesn't appear on the front page. github also uses files with a MARKDONW (.md) extension to show elements on the site (that's why we can use html tags inside it), because github recognizes it like this, we don't see the QR Code component on the front page, but rather what is written in README.md, so that we can see the QR Code component we have to travel to "https://deo-thecoder.github.io/DeosSimpleCoding/qr-code-component-main/QR-index.html".
I don't know if this was your intention from the beginning or not, if it was, I apologize, but I recommend that you make it more explicit so that others can know about it and not get lost. If this was not your intention, I recommend that you place all the files from the "qr-code-component-main" folder in the parent folder, where README.md is located, so that github will recognize index.html first and the image files will continue to render properly without path problems.
An additional task you could do would be to place the README.md files in a separate folder, so that we also avoid other unnecessary problems.
Now, about your QR Code component, it's amazing! Good job! But I recommend you take a look at what I said above.
I hope this has helped, I wish a good luck in your studies and bye bye!!👋👋
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord