Skip to content
Submitted about 2 years ago

QR Code component

stiratto•160
@Stiratto
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I made this project, I added some animations to it for PC, I don't know, I feel that it looks more beautiful, is it? correct me if I did something wrong, although I don't know if in such a case the code can be scanned

Community feedback

  • Adriano•38,040
    @AdrianoEscarabotePosted about 2 years ago

    Hi stiratto, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    1
  • Declan•320
    @engelbrechtzPosted about 2 years ago

    Well Done!!!

    I see that you're using the root element selector in your CSS file for declaring colour variables. I like the keyframes. The animation is neat and minimalist.

    One small change that I would recommend would be to use max-width and max-height for the container element, as this requires you to use fewer media queries as you write out the CSS.

    Overall, Keep coding!!!

    You can review my GitHub projects to gather inspiration if needed. DevDeclann

    Marked as helpful
    1
    stiratto•160
    @StirattoPosted about 2 years ago

    @DevDeclann Thanks for the comments, I'll keep it in mind!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord