Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some feedback for you if you want to improve your code.
HTML 📄:
- In my opinion, the
<section class="main section">
element is unnecessary, because you can place all its styles directly in the body element and have the same result.
- Use the
<main>
tag to wrap all the main content of the page instead of the<div class="main-container">
tag. With this semantic element you can improve the accessibility of your page.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
CSS 🎨:
- Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this two lectures:
Credit to grace-snow and vanzasetia for pointing this out.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
1
Gabriel Müller• 30
@gabrielmulleer
Posted
@MelvinAguilar
Thanks for the feedback, I will use these tips to improve my code
0