QR Code Component (FLEXBOX + MOBILE-FIRST)

Community feedback

• 

  Pedro Celeste•130

  @Pedro-CelestePosted almost 2 years ago

  Hey there! 😎👍🏻

  Good job on finishing this Frontend Mentor challenge :)

  Here are some things that you could do to improve your code:

  HTML:

  • All webpages should be contained in at least one semantic landmark. So instead of using <div class="container"> you can use <main>. This makes webpages more accesible for those using screen readers.

  • The first heading you used in your document was a <h2> element. Headings work based on a structure, so it's generally a good idea to always start off your text with a <h1> instead.

  • 🖼️ Alternative text provided to images don't need to include words like "image", "photo" or "picture", since screen readers already announce that it's an image that we're talking about. Instead of using alt="image-qr-code" you could use something like alt="QR Code that leads to the Frontend Mentor Website".

  CSS:

  These are some small tweaks you could do to make the webpage look a little bit more like the original design.

  • Add a little bit of margin-bottomto the last <p> element to create a little bit of space.

  • Notice that the main container in the original design has a slight box-shadow bellow it. Tip: You coud use rgba or hsla to add opacity to the color of the shadow and make it weaker.

  Additional things:

  • Get in the habit of writing README.md files for your github repository, it can help understand your process and allow other users to give more insightful feedback to your code.

  Thanks for being part of this community, and hope to see more of you code soon!

  Marked as helpful

  1

  ---

  

  idriss kh•370

  @drisskhattabi6Posted almost 2 years ago

  @Pedro-Celeste thanks for advice Bro

  0