QR code component

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 6 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change .container to a <main> - instead of giving <div> a role="main", use the appropriate semantic HTML element available. You should remove role="main", since <main> has an implicit role of main.

  • The alt text must also say where it leads(frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  • If you don't want to include the footer, remove it.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • I would move the properties on .container to body. Change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove all widths in px. Setting fixed sizes causes responsive issues, and is not recommended.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • You don't need justify-content: flex-start, as that is the default value.

  • I would use px instead of % for the image's border-radius.

  • font-family should be placed on the body.

  • Remove the margin on the image, it is centered using Flexbox. Add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  0