qr-code-component

Community feedback

• 

  ErwiniaDev•40

  @ErwiniaDevPosted 17 days ago

  Hi there! First of all, congratulations on your project, it's pretty close to what's expected.

  I've got some feedback if you want, but I'd better warn you, I'm just a beginner so this feedback won't necessarily be the most relevant...

  1. Great, you thought of the "reset.css" file. I didn't know about it before doing this challenge myself. I was advised to put it directly in the "style.css" file for performance reasons.

  2. As this card is not intended to stand alone on a website page, its title is not the title of the page. You can therefore use an h2 instead of your h1.

  3. The body includes the header, main and footer. The footer is not part of the main. And pay attention to indentation in your HTML file.

  4. I think you don't need the div with the class="qr-img", and only one of the div is necessary between card-container and card-content. For my part, I've put the title and text together in a div so that I can easily manage the gap between them, for example. Not sure that's necessary.

  5. The border-radius for the card is 20px (you have 10px). For the padding of the card, it's 16px on the Figma file (you have 20px). And for the font-size of the card title, it seems to be 22px on the Figma file (you have 1.5rem = 24px, you can get 1.4rem I think).

  6. On this last point, I'm not quite sure. In the modern CSS reset, there's line-height: 1.5; but it just seems too big. For my part, I've commented out this line in the modern CSS reset.

  Honestly, nice work. I hope my feedback will be of some use to you and not mislead you.

  All the best!

  0