Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="heading"> with <h1> and <div class="subheading"> and <p> to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful2 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
alt tag
description for the “QR image” needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
- To properly center your content to your page, you will want to add the following to your
body
element (this method uses CSSGrid
):
body { min-height: 100vh; display: grid; place-content: center; }
More Info:📚
[Centering in CSS][https://moderncss.dev/complete-guide-to-centering-in-css/]
- The "Improve your front-end skills by building projects" is a heading, so it needs to wrapped in a
heading
element. While the "Scan the QR code to visit Frontend Mentor and take your coding skills to the next level" should be wrapped inside aparagraph
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎄🎁
Marked as helpful1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord