Qr layout css

Community feedback

• 

  jayanthi•180

  @jrc17Posted almost 2 years ago

  Hello,

  To add the font to your website, you can refer to this video.

  -In the style guide click on the link for the font you want. This is will take you to google fonts.

  • Select the styles you want. -In the selected family, copy the code for HTML(head) and CSS respectively, and paste them into your code.

  1
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  Font

  To fix the font try this

  Do:

  <link rel="preconnect" href="https://fonts.googleapis.com" />
  <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
  <link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap" />
  

  Instead of

  <link rel="stylesheet" href="https://fonts.google.com/specimen/Outfit">
  

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  • You should use a CSS reset to remove the default browser styles and make your page look the same in all browsers.

  Popular CSS resets:

  • Normalize.css
  • Reset CSS

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  0