QR code component

Community feedback

• 

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  Hi EL YOUSFI, how are you?

  Welcome to the front-end mentor community!

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology. To remove the scrollbar, do this:

  body {
      /* margin: 1.25rem; */
      padding: 1.25rem;
  }
  

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0
• 

  Hossam khalaf•230

  @hossam-khalafPosted about 2 years ago

  Hello, @abdelmounime

  Great Effort what you did so far.

  • You can use Semantic Elements like main tag instead of div you can read more about it here: Semantics

  • Also, you can add more padding-bottom or margin-bottom to the p tag to match the design

  Have a great day, Happy Coding😊

  Marked as helpful

  0
• 

  EL YOUSFI•20

  @abdelmounimePosted about 2 years ago

  Hello, @hossam-khalaf Thank you for your feedback, I will take it into consideration by using the Semantic Elements as described. And add more padding-bottom to the p tag to match the design. Thank you again for reaching out and providing us with valuable feedback. Have a great day, Happy Coding 😊

  1