Neil Kanakia• 300
@neilk17
Posted
Hey Rahul,
Congrats on completing your first challenge!
It looks good and congrats on getting the sizes to match perfectly.
A few recommendations:
- The accessibility issues have very simple fixes such as using landmarks (eg: main, header, footer) instead of having all your code in divs.
- The one thing I think you can change is the colors, that have been provided in the styleguide.md file for the fonts. This can be done simply by adding the color attribute in your css file.
0
Rahul Saini• 110
@Rahulnerdy
Posted
@neilk17 thankyou, i will try to fix the issues.
0
