Skip to content
Submitted about 2 years ago

QR code component

Rahul Saini•110
@Rahulnerdy
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

THIS IS MY VERY FIRST PROJECT I AM COMPLETE BEGINNER.. I AM CURRENTLY LEARNING HTML AND CSS... ANY FEEDBACK IS HIGHLY APPRICATED...THANK YOU

Community feedback

  • Neil Kanakia•300
    @neilk17Posted about 2 years ago

    Hey Rahul,

    Congrats on completing your first challenge!

    It looks good and congrats on getting the sizes to match perfectly.

    A few recommendations:

    • The accessibility issues have very simple fixes such as using landmarks (eg: main, header, footer) instead of having all your code in divs.
    • The one thing I think you can change is the colors, that have been provided in the styleguide.md file for the fonts. This can be done simply by adding the color attribute in your css file.
    0
    Rahul Saini•110
    @RahulnerdyPosted about 2 years ago

    @neilk17 thankyou, i will try to fix the issues.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord