QR Code Component

Community feedback

• 

  Mohmed elshaarawy•830

  @MohmedElshaarawyPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page. Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information. Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io CSS 🎨:

  Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘. Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport. I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0

  ---

  

  Noah Ayanbode•140

  @NoahgladPosted almost 2 years ago

  @MohmedElshaarawy Thanks for this wonderful feedback

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Give the alt attribute a value, its value is the description of the image.

  The body has a wrong background-color. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  there is no need to give the body a width value. To center .container on the page using flexbox, replace the height in the bod with min-height: 100vh.

  For a responsive content that wont require a media query for this challenge, replace the width of .container with a fixed max-width value. e,g: max-width: 320px and increase the padding value. there is no need for the height value in .container. the padding value can be a responsive replacement of that. Give the img a max-width of 100% instead of width and height value.

  Give p and h1 the same margin-left, margin-right, margin-top and the same font-size value of 15px. Give p a margin-bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Noah Ayanbode•140

  @NoahgladPosted almost 2 years ago

  @Hassiai Thanks for this great feedback.

  0
• 

  Ahmed Mahrous•980

  @AhmedMahroussPosted almost 2 years ago

  good jop my bro Congrats on completing your first challenge!🎊🍻If you have any questions or need further clarification, feel free to reach out to me. Happy Coding! 🎆🎊

  0