Melvin Aguilar π§π»βπ»β’ 61,140
@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π:
- Use the
<main>
tag to wrap all the main content of the page instead of the<div>
tag. With this semantic element you can improve the accessibility of your page.
CSS π¨:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here π.
- Use
min-height: 100vh
instead ofheight: 100vh
. Theheight
property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
1
P
Chris Cablishβ’ 310
@ChrisCablish
Posted
@MelvinAguilar I will implement these on my next project, thank you!!!!
0