Design comparison
Solution retrospective
š Hello, everyone,
I'm excited to share my solution for the QR Code Component challenge šļø. I built this project using Tailwind CSS and Prettier.
The component is responsive and mobile-first š±, and I learned a lot along the way š”.
š” I'm eager to receive your feedback and suggestions to further improve my solution. Your insights will help me grow and enhance my skills in creating custom features and tweaks.
š Join me on this exciting journey as I take on more challenges and explore new possibilities!
š Thank you for taking the time to review my solution. I can't wait to hear your thoughts and advice!
Community feedback
- @ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.
In order to fix the accessibility issues:
- You need to replace
<div class="container">
with the<main class="container">
tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly. - Each main content needs to include at least h1 element so you should use one
<h1>
element in the<main>
tag. You can replace your<p class="text">Improve your front-end skills by building projects</p>
element with the<h1 class="text">Improve your front-end skills by building projects</h1>
element.
After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.
Hope I am helpful. :)
Marked as helpful1 - You need to replace
- @shiyammmPosted over 1 year ago
Thank you so much for your recommendations regarding my code and fixing the accessibility issues. Your advice to use Semantic HTML and include an <h1> tag in the <main> tag is greatly appreciated, and I will definitely implement those changes to improve the accessibility of my code. Thank you again for your valuable input!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord