QR Code Component

Community feedback

• 

  P

  Darkstar•1,100

  @DarkstarXDDPosted 8 months ago

  • I see you have kept the alt text for the qr code image empty. That should be done if the image is a decorative image. But in this case it's not. So you should give some meaningful text as the alt text for the qr code image.
  • Don't use fixed width for containers. It removes the containers ability to dynamically resize in smaller screen sizes. Instead use max-width. If you use the browser developer tools and scale down the screen size you will see in smaller screens the card is not properly resizing. That is because you have set a fixed width for your card. You can avoid this by using max-width instead of the width property.
  • The card__title would be a <h1> in this case. In a proper website it may be a h2, h3 depending on other content of the page, but since there are no other content in this page you can and should use <h1> instead of <p>. In a webpage there should always be an <h1> tag.

  Other than that you have done a good job!

  Marked as helpful

  0

  ---

  

  P

  Nizi•200

  @XNiziPosted 8 months ago

  Hi @DarkstarXDD 🫡 Really thank you for your feedback and spend time for reading code.

  I must have gotten lost Alt text, I didn't see it. I have a bad habit of making fixed width for containers, thanks for reminder this. However, I think using h1 in this situation is not required because it is component not whole website 😉

  0