Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

Ignacio Spreaficoโ€ข 590

@nachospreafico

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone and happy new year!

I've done this one again to see my progress and I think I did a great job. Used plain HTML and CSS for this one.

Any feedback is very much appreciated!

Cheers!

Community feedback

Daniel ๐Ÿ›ธโ€ข 44,190

@danielmrz-dev

Posted

Hello Ignacio!

Your solution looks excelent, man!

I have just one suggestion for improvement:

  • For semantic reasons, and since that is the main title of the screen, you can replace the <h2> with <h1>.

The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

I hope it helps!

Other than that, you did a great job!

Marked as helpful

2

Ignacio Spreaficoโ€ข 590

@nachospreafico

Posted

@danielmrz-dev thank you very much for your feedback! Will apply this. Have a great day!

1

@MelvinAguilar

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

I have only one suggestion about your code that might interest you.

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

I hope you find it useful! ๐Ÿ˜„

Happy coding!

Marked as helpful

1

Ignacio Spreaficoโ€ข 590

@nachospreafico

Posted

@MelvinAguilar the legend himself! Thank you very much for your feedback. Will apply it on the project. Have a great day!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord